feat: linkedin v2 provider #3804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3804 +/- ##
==========================================
- Coverage 77.97% 77.96% -0.01%
==========================================
Files 357 358 +1
Lines 25138 25166 +28
==========================================
+ Hits 19601 19621 +20
- Misses 4031 4036 +5
- Partials 1506 1509 +3 ☔ View full report in Codecov by Sentry. |
zepatrik
previously approved these changes
Mar 7, 2024
|
All tests fail |
zepatrik
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new "v2" LinkedIn provider that overwrites the issuer URL which is set to
https://www.linkedin.comeven though the discovery URL is underhttps://www.linkedin.com/oauth/.well-known/openid-configuration. The v2 provider uses the generic provider for as much work as possible and only overwrites the concrete issuer URL.Additionally, I had to "discover" the format of the
localeclaim, which is an object for LinkedIn and a string for Discord.The tests "just" test that we can now do a successful discovery.
Additionally, I confirmed this working manually.
Related issue(s)
Fixes #3655
Checklist
introduces a new feature.
contributing code guidelines.
vulnerability. If this pull request addresses a security vulnerability, I
confirm that I got the approval (please contact
security@ory.sh) from the maintainers to push
the changes.
works.
Further Comments